Allow why-comments, sweep narration, and align file layout with namespaces#353
Merged
Conversation
…ayout with namespaces
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rationale) are now allowed; narration/what-comments and section headers inside methods
stay banned. The test-method comment rule is unchanged.
reviewed and either kept as legitimate why-comments or judged out of scope (field/type-level,
not inside a method body).
types are breaking, so the files move instead): Partitioner.cs/PartitionSpec.cs out of a
Partitioning/ subfolder, and two Infrastructure.Relational files into a new OutboxProcessing/
folder mirroring the sibling provider projects.
matching test.
Verification
10/10 including the new guard test).
PublicAPI*.txt/CompatibilitySuppressions.xml: byte-identical (empty diff).Backport to v1.0: no — convention sweep ships with the next release.